Add comprehensive tests to test the kernel across available dtypes. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashu123
force-pushed
the
add_tests
branch
3 times, most recently
from
05d834c
to
f09dfab
Compare
Groverkss
reviewed
Feb 27, 2024
core/tests/kernel/coverage_test.py
Outdated
| import pytest | ||
|
|
||
|
|
||
| TKL_TO_TORCH_DTYPE = { |
There was a problem hiding this comment.
Can we add this to DataType as a method? a from_torch_type and to_torch_type would be good to have.
Added softmax and gemm kernel to test across the available float and int dtypes.
|
is this stale? |
@Groverkss Is this required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added softmax and gemm kernel to test across the available float and int dtypes.